Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-842 Sqoop2: Put partition to template in Extractor as well


+
Jarek Cecho 2013-01-23, 17:11
Copy link to this message
-
Re: Review Request: SQOOP-842 Sqoop2: Put partition to template in Extractor as well
Cheolsoo Park 2013-01-30, 23:09

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9068/#review15895
-----------------------------------------------------------

Ship it!
LGTM. I will commit it after running tests.

- Cheolsoo Park
On Jan. 23, 2013, 5:11 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9068/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 5:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've put the partition to template as proposed on jira.
>
>
> This addresses bug SQOOP-842.
>     https://issues.apache.org/jira/browse/SQOOP-842
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java f4389a3a39c41398fc6d30a0f8282321f3a8ed5c
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java 3a04e59dcc3723e16fadf6cfced8c9134c253339
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java e00d4287eadf5c93ad9e44930efeea76221d7071
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java 4e6209d73475bcae078e03c222ffc0bcf6d87beb
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 85900650051d1e6f90725f872968ad623df32636
>   spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java fac6f052bdf2a328839508d2f81a3dada3b0aeea
>
> Diff: https://reviews.apache.org/r/9068/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've also tried import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>