Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: Sqoop2: Help option for shell command functions


+
rj.vasanthkumar@... 2013-03-24, 20:46
+
Abraham Elmahrek 2013-03-26, 02:59
+
rj.vasanthkumar@... 2013-03-29, 20:43
+
rj.vasanthkumar@... 2013-04-08, 20:28
+
Jarek Cecho 2013-04-13, 19:01
+
rj.vasanthkumar@... 2013-04-13, 19:50
+
rj.vasanthkumar@... 2013-04-15, 10:07
Copy link to this message
-
Re: Review Request: Sqoop2: Help option for shell command functions
Jarek Cecho 2013-04-15, 04:07


> On April 13, 2013, 7:01 p.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java, lines 46-49
> > <https://reviews.apache.org/r/10100/diff/3/?file=279012#file279012line46>
> >
> >     I would argue that this might be quite confusing for end user as "show connection --jid 1 help" will show the help but "show connection help --jid 1" won't. I think that using just the "help" command for getting help will be enough, what do you think?
>
> vasanthkumar wrote:
>     Hi Jarek,
>     Thank you for your review comments. I am fine with your suggestion. Current patch we append word "help" while using help for functions and again execute command. Now to avoid help at the end of command, we have to use a internal help flag to display help. Such that help flag will be appended in help command and check for the flag in SqoopFunction. This way make simple and we have to hard code the help flag.
>    
>     Otherwise, if(args.contains(Constants.CMD_HELP)) will work for both the way.
>    
>     Kindly suggest

Hi Vasanth,
my proposal is not to change the execute() method of each function at all. Instead we can just create smart enough help command that will inspect other commands/functions and display the help accordingly.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10100/#review19127
-----------------------------------------------------------
On April 8, 2013, 8:28 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10100/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 8:28 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> There is no help option for shell command's functions. Introducing the help argument for functions.
>
>
> This addresses bug sqoop-965.
>     https://issues.apache.org/jira/browse/sqoop-965
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java c6f831d
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
>
> Diff: https://reviews.apache.org/r/10100/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>