Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-804 Warn if hive special arguments will be used without --hive-import


Copy link to this message
-
Review Request: SQOOP-804 Warn if hive special arguments will be used without --hive-import

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8778/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've added simple check to see if user specified one of hive specific arguments without --hive-import. This patch is introducing one additional checkstyle warning complaining about size of SqoopOptions class. I would suggest to solve that in separate jira as refactoring SqoopOption won't be simple task.
This addresses bug SQOOP-804.
    https://issues.apache.org/jira/browse/SQOOP-804
Diffs
-----

  src/java/com/cloudera/sqoop/SqoopOptions.java 8d4f20264cf1f9e5897233dc6c28eb349ecff90d
  src/java/org/apache/sqoop/SqoopOptions.java 613f7978ea5907854439e9013bec0dbde18e8da3
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java d79564629ba89c539730cf5209c06c7ef694df4e

Diff: https://reviews.apache.org/r/8778/diff/
Testing
-------

Tested on real cluster on various scenarios and parameter combinations.
Thanks,

Jarek Cecho

+
Cheolsoo Park 2013-01-04, 10:12