-
Re: Review Request: PIG-3050 Fix FindBugs multithreading warningsSanthosh Srinivasan 2012-12-27, 02:52
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8649/#review14936
-----------------------------------------------------------
Ship it!
+1. Looks good and is in synch with your comments on the jira.
- Santhosh Srinivasan
On Dec. 17, 2012, 7:04 p.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8649/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2012, 7:04 p.m.)
>
>
> Review request for pig and Santhosh Srinivasan.
>
>
> Description
> -------
>
> Please see https://issues.apache.org/jira/browse/PIG-3050
>
>
> This addresses bug PIG-3050.
> https://issues.apache.org/jira/browse/PIG-3050
>
>
> Diffs
> -----
>
> src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java 9b8223d
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java ee4d52a
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POProject.java 5195dee
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserComparisonFunc.java fcaf9b0
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java df1af28
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POFRJoin.java 58a8892
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POForEach.java 0a69ef2
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POJoinPackage.java d1283b8
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPackage.java 6bbe5e0
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPackageLite.java 8ab351d
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POStream.java e3379c8
> src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POUnion.java b29c481
> src/org/apache/pig/data/DefaultAbstractBag.java 816143f
> src/org/apache/pig/data/NonSpillableDataBag.java 6b59c8f
> src/org/apache/pig/data/SchemaTupleBackend.java 6f0ad3b
> src/org/apache/pig/impl/util/SpillableMemoryManager.java 403d774
>
> Diff: https://reviews.apache.org/r/8649/diff/
>
>
> Testing
> -------
>
> Verified that both unit test and e2e test pass.
>
>
> Thanks,
>
> Cheolsoo Park
>
>
