Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive, mail # dev - Review Request: HIVE-4119: ANALYZE TABLE ... COMPUTE STATISTICS FOR COLUMNS fails with NPE if the table is empty


+
Shreepadma Venugopalan 2013-03-14, 20:53
+
Carl Steinbach 2013-03-22, 08:19
Copy link to this message
-
Re: Review Request: HIVE-4119: ANALYZE TABLE ... COMPUTE STATISTICS FOR COLUMNS fails with NPE if the table is empty
Shreepadma Venugopalan 2013-03-23, 01:32

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9929/#review18308
-----------------------------------------------------------
Thanks for the comments Carl. Addresses review comments from revision 1.
ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java
<https://reviews.apache.org/r/9929/#comment38515>

    Done.

ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java
<https://reviews.apache.org/r/9929/#comment38516>

    Done

ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/9929/#comment38518>

    done

ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/9929/#comment38519>

    done

ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/9929/#comment38517>

    done
- Shreepadma Venugopalan
On March 14, 2013, 8:53 p.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9929/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 8:53 p.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> Enhances the column stats UDF and column stats task to handle empty tables. Adds new q file tests.
>
>
> This addresses bug HIVE-4119.
>     https://issues.apache.org/jira/browse/HIVE-4119
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java de28766
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java 0e3846e
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java e09efb7
>   ql/src/test/queries/clientpositive/columnstats_tbllvl.q 187e8be
>   ql/src/test/queries/clientpositive/compute_stats_empty_table.q PRE-CREATION
>   ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 3390ca0
>   ql/src/test/results/clientpositive/compute_stats_empty_table.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9929/diff/
>
>
> Testing
> -------
>
> Adds new q file tests which test column stats against an empty table.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>

+
Shreepadma Venugopalan 2013-03-23, 01:32