Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 13636: SQOOP-1170: Can't import columns with name "public"


Copy link to this message
-
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Erik Selin 2013-08-19, 23:00


> On Aug. 18, 2013, 7 p.m., Jarek Cecho wrote:
> > Hi Erik,
> > the changes looks about right. Would you mind adding test to TestClassWriter to ensure that we want regress from this functionality?
> >
> > Jarcec
>
> Erik Selin wrote:
>     Hey, I sure could but this is such a tiny change I don't really see what you would like me to test for? I could add a line to
>    
>         assertEquals("_public", ClassWriter.toJavaIdentifier("public"));
>    
>     but that just seems redundant since we're not testing for any of the other JAVA_RESERVED_WORDS?
>
> Jarek Cecho wrote:
>     I think that we actually should be doing exactly that, so If you feel up to, don't hesitate and add the tests for all entries from JAVA_RESERVED_WORDS. Otherwise please just add this one and we will create follow up JIRA to add the others.

This should be even better. I added a test for each keyword, added a few more missing ones and sorted the lists so that they are more manageable.
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25279
-----------------------------------------------------------
On Aug. 19, 2013, 10:59 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
>   src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
>   src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
>   src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>