Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop


+
Mengwei Ding 2013-05-30, 23:36
+
Mengwei Ding 2013-05-30, 23:40
+
Mengwei Ding 2013-05-30, 23:42
+
Abraham Elmahrek 2013-05-30, 23:52
+
Mengwei Ding 2013-05-31, 00:12
+
Mengwei Ding 2013-06-05, 16:51
+
Mengwei Ding 2013-05-31, 00:14
+
Mengwei Ding 2013-06-04, 23:46
+
Jarek Cecho 2013-06-05, 00:24
+
Jarek Cecho 2013-06-05, 00:46
+
Mengwei Ding 2013-06-05, 00:43
Copy link to this message
-
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
Jarek Cecho 2013-06-05, 14:43

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21481
-----------------------------------------------------------
Hi Mengwei,
thank you very much for working on this patch. I do have just one nit:
docs/src/site/sphinx/CommandLineClient.rst
<https://reviews.apache.org/r/11561/#comment44487>

    Nit: I would recommend putting here a note that the value is expected to be in milliseconds.
Jarcec

- Jarek Cecho
On June 4, 2013, 11:46 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:46 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 6d2a4bb0331210cda99d571579705084b12fb357
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Thu May 30 16:30:53 2013 -0700
>
>     SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 2158458... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
>     https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
>   client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
>   client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
>   client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
>   client/src/main/resources/client-resource.properties e328f9a
>   docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>

+
Mengwei Ding 2013-06-05, 16:49
+
Mengwei Ding 2013-06-05, 17:27
+
Jarek Cecho 2013-06-05, 21:13
+
Mengwei Ding 2013-06-05, 21:25
+
Mengwei Ding 2013-06-05, 17:24