Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: Sqoop2: Move string constants from FormDisplayer to resource file


Copy link to this message
-
Re: Review Request: Sqoop2: Move string constants from FormDisplayer to resource file
vasanth kumar 2013-03-11, 05:40
Sure. I will update the patch again.

Thanks,
Vasanth
On Mon, Mar 11, 2013 at 11:05 AM, Jarek Cecho <[EMAIL PROTECTED]> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9669/
>
> Hi Vasanth,
> would you mind rebasing your changes with current changes in head of the sqoop2 branch? I'll be happy to help or to take it from here if you're not interested any more.
>
> Jarcec
>
>
> - Jarek
>
> On February 28th, 2013, 3:04 a.m., vasanthkumar wrote:
>   Review request for Sqoop.
> By vasanthkumar.
>
> *Updated Feb. 28, 2013, 3:04 a.m.*
> Description
>
> Move string constants from FormDisplayer to resource file
>
>   Testing
>
> Done
>
>   *Bugs: * SQOOP-887 <https://issues.apache.org/jira/browse/SQOOP-887>
> Diffs
>
>    - client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
>    (af325d5)
>    - client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
>    (c2464d2)
>    - client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java
>    (31de8dc)
>    - client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
>    (0d67133)
>    - client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
>    (4d0442f)
>    - client/src/main/resources/client-resource.properties (58cfe55)
>
> View Diff <https://reviews.apache.org/r/9669/diff/>
>

--
Regards
Vasanth kumar RJ