-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8672/
-----------------------------------------------------------

Review request for Flume.
Description
-------

Implements caching of usable space.  The cache is refreshed every 15 seconds.  Also cleans up a few compiler warnings in file channel.
This addresses bug FLUME-1794.
    https://issues.apache.org/jira/browse/FLUME-1794
Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java af11dc5
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 8089ff3
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 3d5bf59
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java f9dbba5
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestTransactionEventRecordV3.java 274ee7b

Diff: https://reviews.apache.org/r/8672/diff/
Testing
-------

Unit test added and passes
Thanks,

Brock Noland

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8672/#review14687
-----------------------------------------------------------

Ship it!
Ship It!

- Hari Shreedharan
On Dec. 18, 2012, 9 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8672/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 9 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Implements caching of usable space.  The cache is refreshed every 15 seconds.  Also cleans up a few compiler warnings in file channel.
>
>
> This addresses bug FLUME-1794.
>     https://issues.apache.org/jira/browse/FLUME-1794
>
>
> Diffs
> -----
>
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java af11dc5
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 8089ff3
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 3d5bf59
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java f9dbba5
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestTransactionEventRecordV3.java 274ee7b
>
> Diff: https://reviews.apache.org/r/8672/diff/
>
>
> Testing
> -------
>
> Unit test added and passes
>
>
> Thanks,
>
> Brock Noland
>
>

> On Dec. 18, 2012, 9:31 p.m., Hari Shreedharan wrote:
> > Ship It!

I am getting a test failure:
testMinimumRequiredSpaceTooSmallForPut(org.apache.flume.channel.file.TestLog)
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8672/#review14687
-----------------------------------------------------------
On Dec. 18, 2012, 9 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8672/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 9 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Implements caching of usable space.  The cache is refreshed every 15 seconds.  Also cleans up a few compiler warnings in file channel.
>
>
> This addresses bug FLUME-1794.
>     https://issues.apache.org/jira/browse/FLUME-1794
>
>
> Diffs
> -----
>
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java af11dc5
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 8089ff3
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 3d5bf59
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java f9dbba5
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestTransactionEventRecordV3.java 274ee7b
>
> Diff: https://reviews.apache.org/r/8672/diff/
>
>
> Testing
> -------
>
> Unit test added and passes
>
>
> Thanks,
>
> Brock Noland
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8672/
-----------------------------------------------------------

(Updated Dec. 18, 2012, 10:48 p.m.)
Review request for Flume.
Changes
-------

Addresses unit test failure. Unit test was failing due to a cached value.
Description
-------

Implements caching of usable space.  The cache is refreshed every 15 seconds.  Also cleans up a few compiler warnings in file channel.
This addresses bug FLUME-1794.
    https://issues.apache.org/jira/browse/FLUME-1794
Diffs (updated)
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java af11dc5
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 8089ff3
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java 1fe219a
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV2.java 4c593a4
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java aac7805
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 3d5bf59
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java f9dbba5
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java 9e28599
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestTransactionEventRecordV3.java 274ee7b

Diff: https://reviews.apache.org/r/8672/diff/
Testing
-------

Unit test added and passes
Thanks,

Brock Noland