Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-2048 Avro container file deserializer


Copy link to this message
-
Re: Review Request: FLUME-2048 Avro container file deserializer
Israel Ekpo 2013-05-23, 10:59

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11342/#review20936
-----------------------------------------------------------

flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventDeserializer.java
<https://reviews.apache.org/r/11342/#comment43116>

    I think the style should be consistent with how it is done one line 108.
    
    The setting of the position should be on a separate line below the test and should be enclosed with braces.
- Israel Ekpo
On May 23, 2013, 10:15 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11342/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 10:15 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Spooling directory source deserializer for Avro container files.
>
>
> Diffs
> -----
>
>   flume-ng-core/pom.xml 20e975f
>   flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventDeserializer.java PRE-CREATION
>   flume-ng-core/src/main/java/org/apache/flume/serialization/EventDeserializerType.java 02abc80
>   flume-ng-core/src/main/java/org/apache/flume/serialization/LengthMeasurable.java PRE-CREATION
>   flume-ng-core/src/main/java/org/apache/flume/serialization/RemoteMarkable.java PRE-CREATION
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java 49521ab
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestAvroEventDeserializer.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TransientPositionTracker.java PRE-CREATION
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 1b4d216
>   pom.xml a6992f6
>
> Diff: https://reviews.apache.org/r/11342/diff/
>
>
> Testing
> -------
>
> Included a unit test
>
>
> Thanks,
>
> Mike Percy
>
>