Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Re: pig pull request: Fix newline right after quote


Copy link to this message
-
Re: pig pull request: Fix newline right after quote
Committed today, thanks both.

D

On Sat, Aug 18, 2012 at 9:26 AM, Віталій Тимчишин <[EMAIL PROTECTED]> wrote:
> I understand. I did add patch to PIG-2556 at the same time. Patch is
> generated with git, if it's not OK I can try to redo it.
> See
> https://issues.apache.org/jira/secure/attachment/12541355/CSVExcelProblems-2.patch
>
> 2012/8/17 Jonathan Coveney <[EMAIL PROTECTED]>
>
>> Howdy Vitalii,
>>
>> We actually can't merge in pull requests via github. It's purely a mirror.
>>
>> The version control of truth is subversion, and you need to submit a patch
>> to a ticket via JIRA.
>>
>> Thanks for your submission, but alas, github isn't the way to do it yet.
>> This has it's good and bade sides, but hope it will not discourage you from
>> contributing
>> Jon
>>
>> 2012/8/17 tivv <[EMAIL PROTECTED]>
>>
>>> GitHub user tivv opened a pull request:
>>>
>>>     https://github.com/apache/pig/pull/6
>>>
>>>     Fix newline right after quote
>>>
>>>     PIG-2556 PiggyBank CSVExcelStorage treats "\nData" field incorrectly
>>> in multiline mode
>>>
>>> You can merge this pull request into a Git repository by running:
>>>
>>>     $ git pull https://github.com/tivv/pig CSVExcelNewLineBug
>>>
>>> Alternatively you can review and apply these changes as the patch at:
>>>
>>>     https://github.com/apache/pig/pull/6.patch
>>>
>>> ----
>>> commit c2c077c30d3934577425f351eb097778047ad7b2
>>> Author: Vitalii Tymchyshyn <[EMAIL PROTECTED]>
>>> Date:   2012-08-17T05:17:46-07:00
>>>
>>>     Fix newline right after quote
>>>
>>> ----
>>>
>>>
>>
>
>
> --
> Best regards,
>  Vitalii Tymchyshyn
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB