Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Re: Review Request: JMX support for SpoolDir Source


Copy link to this message
-
Re: Review Request: JMX support for HTTP Source.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11811/#review22280
-----------------------------------------------------------
Looks almost ready to go. Just one issue below.
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java
<https://reviews.apache.org/r/11811/#comment45771>

    This really represents the number of client connections made. Either this should be updated when a client connection is made (not sure whether Jetty provides an option for a callback) or should not be set at all (which represents that that counter is never updated).
- Hari Shreedharan
On June 20, 2013, 10:23 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11811/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 10:23 p.m.)
>
>
> Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan.
>
>
> Description
> -------
>
> Http Source supports following metrics:
> START
> STOP
> OPEN_CONNECTION_COUNT
> EVENTS_RECEIVED
> EVENTS_ACCEPTED
>
> Some points for discussion:
> 1. Should we support APPEND_BATCH_RECEIVED and APPEND_BATCH_ACCEPTED ?
> Http doesnt have a batch setting, but multiple events can be sent in a single POST request.
> 2. Is EVENTS_RECEIVED always same as APPEND_RECEIVED?
> Went over all the sources which support jmx metrics and it looks like they are redundant and never actually used separately.
>
>
> This addresses bug FLUME-2076.
>     https://issues.apache.org/jira/browse/FLUME-2076
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java a4c3eb3
>
> Diff: https://reviews.apache.org/r/11811/diff/
>
>
> Testing
> -------
>
> Ran existing tests
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>