Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: Sqoop2: Devguide: Describe client API for embedding Sqoop client in applications


+
rj.vasanthkumar@... 2013-04-03, 20:15
+
rj.vasanthkumar@... 2013-04-03, 20:25
+
rj.vasanthkumar@... 2013-04-06, 17:50
Copy link to this message
-
Re: Review Request: Sqoop2: Devguide: Describe client API for embedding Sqoop client in applications

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10271/#review18757
-----------------------------------------------------------
Hi Vasanth,
thank you for putting this together. I do have few nites:
docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/10271/#comment39167>

    Nit: will explain
    

docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/10271/#comment39168>

    Would you mind using normal enumeration without the "code" mode?

docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/10271/#comment39169>

    Sqoop common is not explicitly needed as sqoop-client have it as it's dependency.

docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/10271/#comment39171>

    Can we also change the "2.0.0-SNAPHOST" to same variable like "${requestedVersion}?

docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/10271/#comment39170>

    I would prefer not to suggest manual addition of jars to classpath. Let's just stick with maven dependencies for now.
- Jarek Cecho
On April 6, 2013, 5:50 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10271/
> -----------------------------------------------------------
>
> (Updated April 6, 2013, 5:50 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Sqoop 2 client API Developer guide.
>
> Also updated copyright information.
>
>
> This addresses bug sqoop-925.
>     https://issues.apache.org/jira/browse/sqoop-925
>
>
> Diffs
> -----
>
>   docs/src/site/sphinx/ClientAPI.rst PRE-CREATION
>   docs/src/site/sphinx/conf.py 642d065
>   docs/src/site/sphinx/index.rst 02dce33
>
> Diff: https://reviews.apache.org/r/10271/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>

+
rj.vasanthkumar@... 2013-04-07, 14:03
+
Jarek Cecho 2013-04-13, 18:46
+
rj.vasanthkumar@... 2013-04-06, 17:27
+
rj.vasanthkumar@... 2013-04-06, 22:30
+
Jarek Cecho 2013-04-06, 23:07