Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-786 Sqoop2: Include jars from WAR archive in LICENSE.txt file


+
Jarek Cecho 2012-12-17, 20:03
Copy link to this message
-
Re: Review Request: SQOOP-786 Sqoop2: Include jars from WAR archive in LICENSE.txt file
Cheolsoo Park 2012-12-17, 21:14

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8650/#review14610
-----------------------------------------------------------
Hi Jarcec,

Here is the dependencies that I see. Do we want to list all of them? If so, I see some missing ones in your patch.

[cheolsoo@cheolsoo-mr2-1 webapps]$ jar -tvf sqoop.war | grep "\.jar" | grep -v hadoop | grep -v sqoop | awk '{ print $8}' | sort -u
WEB-INF/lib/avro-1.7.1.cloudera.2.jar
WEB-INF/lib/commons-cli-1.2.jar
WEB-INF/lib/commons-configuration-1.6.jar
WEB-INF/lib/commons-dbcp-1.4.jar
WEB-INF/lib/commons-lang-2.5.jar
WEB-INF/lib/commons-logging-1.1.1.jar
WEB-INF/lib/commons-pool-1.5.4.jar
WEB-INF/lib/derby-10.8.2.2.jar
WEB-INF/lib/guava-11.0.2.jar
WEB-INF/lib/jackson-core-asl-1.8.8.jar
WEB-INF/lib/jackson-mapper-asl-1.8.8.jar
WEB-INF/lib/json-simple-1.1.jar
WEB-INF/lib/log4j-1.2.16.jar
WEB-INF/lib/protobuf-java-2.4.0a.jar
WEB-INF/lib/slf4j-api-1.6.1.jar
WEB-INF/lib/slf4j-log4j12-1.6.1.jar

- Cheolsoo Park
On Dec. 17, 2012, 8:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8650/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2012, 8:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've listed all third party jars that are shipped as a part of our server war file.
>
>
> This addresses bug SQOOP-786.
>     https://issues.apache.org/jira/browse/SQOOP-786
>
>
> Diffs
> -----
>
>   LICENSE.txt 09d993d86befd1e6a9267e1371831dd7ac3e3497
>
> Diff: https://reviews.apache.org/r/8650/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Jarek Cecho 2012-12-17, 21:35
+
Cheolsoo Park 2012-12-17, 22:05