Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that


Copy link to this message
-
Re: Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12032/#review22925
-----------------------------------------------------------
Hi Raghav,
thank you very much for the explanation. I do understand the desire to keep backward compatibility. Overriding column type to a TIMESTAMP every time seems to me to as clear bug that just happen to surface when the Oracle Connector is in use. Therefore I would suggest to fix that bug rather then delegating fix to the connector.

Jarcec

- Jarek Cecho
On July 1, 2013, 8:02 p.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12032/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 8:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-906
>     https://issues.apache.org/jira/browse/SQOOP-906
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Incremental import using lastmodified mode always assumes column type to be TIMESTAMP which is causing issues with Oracle Connector. This patch fixes that.
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/manager/ConnManager.java c9e05da
>   src/java/org/apache/sqoop/manager/OracleManager.java edc888e
>   src/java/org/apache/sqoop/tool/ImportTool.java cb800b6
>   src/test/com/cloudera/sqoop/manager/OracleIncrementalImportTest.java PRE-CREATION
>   src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 877d7f8
>
> Diff: https://reviews.apache.org/r/12032/diff/
>
>
> Testing
> -------
>
> Unit tests & oracle third party tests are passing. Also tested manually.
>
>
> Thanks,
>
> Raghav Gautam
>
>