Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 17035: DRILL-334 Bit RPC socket split, Memory leak fixes - author: Jacques


Copy link to this message
-
Re: Review Request 17035: DRILL-334 Bit RPC socket split, Memory leak fixes - author: Jacques

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17035/#review32128
-----------------------------------------------------------

exec/java-exec/src/main/java/org/apache/drill/exec/memory/AccountingByteBuf.java
<https://reviews.apache.org/r/17035/#comment60812>

    Is the comment suggesting a TODO? it looks like it's just throwing UnsupportedOperation in the end anyways.

exec/java-exec/src/main/java/org/apache/drill/exec/memory/AccountingByteBuf.java
<https://reviews.apache.org/r/17035/#comment60813>

    Shouldn't take the endianness into account?

exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java
<https://reviews.apache.org/r/17035/#comment60814>

    Unused? same as the next constant

exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java
<https://reviews.apache.org/r/17035/#comment60817>

    I'm scanning files in the order in this reviewboard, so maybe I don't have all the context yet, but why we don't try to use parent allocator when there is no preallocated memory but we do that when there is?
    

exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java
<https://reviews.apache.org/r/17035/#comment60816>

    remove

exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java
<https://reviews.apache.org/r/17035/#comment60818>

    Don't you need to also return the unaccount size you allocated from parent too?

exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java
<https://reviews.apache.org/r/17035/#comment60819>

    Doesn't seem like you always allocate from parent (ie: when no preallocated)
- Timothy Chen
On Jan. 17, 2014, 5:51 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17035/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 5:51 a.m.)
>
>
> Review request for drill.
>
>
> Bugs: 334
>     https://issues.apache.org/jira/browse/334
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Drill 334
>
>
> Diffs
> -----
>
>   common/src/main/java/org/apache/drill/common/config/DrillConfig.java ffbf910
>   exec/bufferl/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBufL.java e5e1d20
>   exec/java-exec/pom.xml 2ffdae9
>   exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 465813c
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedCache.java aed6cc2
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMap.java b7595f9
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMultiMap.java 886f122
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/HazelCache.java 9dd4373
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/LocalCache.java e6275c1
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/ProtoBufImpl.java d03eac8
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/ProtoBufWrap.java 448eecd
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java 656d07f
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 8ee9042
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DumpCat.java ef0b1e1
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/AccountingByteBuf.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/BufferAllocator.java 1584092
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/DirectBufferAllocator.java 77a251d
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/OutOfMemoryException.java PRE-CREATION