Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Uppercase table name and table owner name.


Copy link to this message
-
Re: Review Request: Uppercase table name and table owner name.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/#review4133
-----------------------------------------------------------
Eric - thanks for the patch. Were you able to successfully import data from a table with mixed/lower case name? When I tried out your change, I ran into https://issues.apache.org/jira/browse/CLI-185 which is fixed for 1.3 release of Commons-CLI but there does not seem to be an ETA on that release yet.

- Arvind
On 2011-12-21 19:03:52, Eric Wadsworth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3266/
> -----------------------------------------------------------
>
> (Updated 2011-12-21 19:03:52)
>
>
> Review request for Sqoop.
>
>
> Summary
> -------
>
> Uppercase table name and table owner name if it's not surrounded by double quotes.
>
>
> This addresses bug SQOOP-415.
>     https://issues.apache.org/jira/browse/SQOOP-415
>
>
> Diffs
> -----
>
>   /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1221519
>   /src/java/org/apache/sqoop/manager/OracleManager.java 1221519
>
> Diff: https://reviews.apache.org/r/3266/diff
>
>
> Testing
> -------
>
> This patch includes a unit test. Before the patch, sqoop fails for me when connecting to oracle. When built with this patch, it works. "ant test" passes.
>
>
> Thanks,
>
> Eric
>
>