Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: Support for batch size in StressSource


+
Ted Malaska 2012-09-07, 01:06
+
Brock Noland 2012-09-07, 14:59
+
Ted Malaska 2012-09-07, 15:21
+
Ted Malaska 2012-09-07, 18:25
+
Will McQueen 2012-09-07, 18:37
Copy link to this message
-
Re: Review Request: Support for batch size in StressSource
Will McQueen 2012-09-07, 18:46

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6949/#review11172
-----------------------------------------------------------

flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java
<https://reviews.apache.org/r/6949/#comment23891>

    Agreed. Also, please use interface "List" instead of impl "ArrayList" as the type.

flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java
<https://reviews.apache.org/r/6949/#comment23892>

    Agreed

flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java
<https://reviews.apache.org/r/6949/#comment23893>

    Also, please return List<Event> instead of ArrayList<Event>

flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java
<https://reviews.apache.org/r/6949/#comment23894>

    batchs => batches

flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java
<https://reviews.apache.org/r/6949/#comment23895>

    successful => successful events

flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java
<https://reviews.apache.org/r/6949/#comment23896>

    failure => failed events
- Will McQueen
On Sept. 7, 2012, 6:25 p.m., Ted Malaska wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6949/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2012, 6:25 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Adding batchSize to StressSource along with junit to test it.  
>
> Important note: the total number of events getting sent will equals maxTotalEvents, so if maxTotalEvents is not devisable by batchSize then the last batch will contain only the remainder of events needed to reach maxTotalEvents.
>
>
> This addresses bug FLUME-1536.
>     https://issues.apache.org/jira/browse/FLUME-1536
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 5b73910
>   flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 4ec16c7
>
> Diff: https://reviews.apache.org/r/6949/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ted Malaska
>
>

+
Ted Malaska 2012-09-07, 19:12
+
Ted Malaska 2012-09-10, 14:06
+
Brock Noland 2012-09-10, 15:20