Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Implementing the Query resource


Copy link to this message
-
Re: Implementing the Query resource
Srihari Srinivasan 2013-07-28, 17:25
This should be possible. I'll try and see how it goes!

On Sat, Jul 27, 2013 at 7:09 PM, Jacques Nadeau <[EMAIL PROTECTED]> wrote:

> I suggest you define a generic Drill bit Service interface that receives
> the drill configuration and is started/stopped and then use drill module
> conf and cp scanning similar to how we incorporate CallProviders or
> DrillFuncs. Then switch the dependency direction using the pom snippet I
> provided and have your service implement this new interface..
> Thoughts?
> On Jul 27, 2013 6:32 AM, "Srihari Srinivasan" <[EMAIL PROTECTED]>
> wrote:
>
> > The HttpEngine class which encapsulates the Jetty server is instantiated
> > from the Drillbit class to start the web server. So java-exec depends on
> > http-engine.
> >
> > Happy to have a quick hangout on this if you have the time...
> >
> > Hari
> >
> > On Sat, Jul 27, 2013 at 6:42 PM, Jacques Nadeau <[EMAIL PROTECTED]>
> > wrote:
> >
> > > I didn't realize that.  Why do you have that dependency?
> > > On Jul 27, 2013 5:04 AM, "Srihari Srinivasan" <
> [EMAIL PROTECTED]
> > >
> > > wrote:
> > >
> > > > If I understand correctly what you are suggesting is we add the
> snippet
> > > > below in the http-engine's pom file. Since I already have java-exec
> > > depend
> > > > on http-engine won't this make it a case of having cyclic
> dependencies
> > > that
> > > > mvn will complain about?
> > > >
> > > > Hari
> > > >
> > > > On Fri, Jul 26, 2013 at 11:07 PM, Jacques Nadeau <[EMAIL PROTECTED]
> >
> > > > wrote:
> > > >
> > > > > Let's get an alpha out before we break out the client.
> > > > >
> > > > > In the meantime, I downloaded your stuff and it seemed to work fine
> > > > > when it depends on java-exec.
> > > > >
> > > > > I'd suggest you use the dependency like this to avoid any weird
> > > > conflicts:
> > > > >
> > > > >         <dependency>
> > > > >           <groupId>org.apache.drill.exec</groupId>
> > > > >           <artifactId>java-exec</artifactId>
> > > > >           <version>1.0-SNAPSHOT</version>
> > > > >           <exclusions>
> > > > >             <exclusion>
> > > > >               <artifactId>jsp-api-2.1</artifactId>
> > > > >               <groupId>org.mortbay.jetty</groupId>
> > > > >             </exclusion>
> > > > >             <exclusion>
> > > > >               <artifactId>jetty</artifactId>
> > > > >               <groupId>org.mortbay.jetty</groupId>
> > > > >             </exclusion>
> > > > >           </exclusions>
> > > > >         </dependency>
> > > > >
> > > > >
> > > > >
> > > > > On Fri, Jul 26, 2013 at 9:50 AM, Srihari Srinivasan
> > > > > <[EMAIL PROTECTED]> wrote:
> > > > > > Hi All,
> > > > > >
> > > > > > Any thoughts on the DrillClient modularization/short term
> > > alternative?
> > > > > >
> > > > > > Hari
> > > > > >
> > > > > >
> > > > > > ---------- Forwarded message ----------
> > > > > > From: Srihari Srinivasan <[EMAIL PROTECTED]>
> > > > > > Date: Tue, Jul 23, 2013 at 10:33 PM
> > > > > > Subject: Re: Meeting today
> > > > > > To: [EMAIL PROTECTED]
> > > > > > Cc: [EMAIL PROTECTED]
> > > > > >
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > Quick note on what we discussed w.r.t the REST API.
> > > > > >
> > > > > > I am at a point where to submit a query (logical for now) to the
> > > > > Drillbit I
> > > > > > need an instance of the DrillClient class from the Query REST
> > > resource.
> > > > > > DrillClient is currently part of the java-exec module. I've
> pulled
> > > out
> > > > > the
> > > > > > jersey/jetty stuff into its own mvn module to keep the concerns
> > > > separate.
> > > > > >
> > > > > > So the really question is - Is now a good time to pull out
> > > DrillClient
> > > > > and
> > > > > > its dependencies into its own client module? That way http-engine
> > can
> > > > > just
> > > > > > depend on the client lib. Having this will be a huge help as it
> can
> > > > > > potentially keep a parallel stream of working going.