Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms


Copy link to this message
-
Re: Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms
Michael Berman 2013-11-08, 21:28


> On Nov. 1, 2013, 9:37 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/ConfiguratorBase.java, line 302
> > <https://reviews.apache.org/r/14972/diff/1/?file=371869#file371869line302>
> >
> >     There's really too many methods here. If we're going to provide an alternate way to set configuration on a M/R job, we shouldn't take some properties, plus a configuration object with other properties... we should just take the configuration object and expect it to include all the necessary options.
>
> John Vines wrote:
>     Please see discussion https://reviews.apache.org/r/14972/#comment53742
>
> Christopher Tubbs wrote:
>     I'll retract this comment. I was thinking this was public API, but it's not. It's in the utility class.
>
> Michael Berman wrote:
>     I did end up cleaning it up following that discussion upthread, since it was bugging me anyway.
>    
>     Are you sure this isn't in the public API, though?  I figured this is the method people would use in their own MR jobs, for passing configuration to accumulo's In/OutputFormats.  If I've misunderstood how this code gets consumed, and it's not really public, I'll skip the deprecation cycle and just get rid of the old ones now.
>
> Christopher Tubbs wrote:
>     ConfiguratorBase, along with all the classes in this util package, is an internal util class shared between mapred and mapreduce implementations for the implementation of the static configurator methods on the specific {Input,Output}Format. The public API for this is the static methods on the actual InputFormat and OutputFormat classes.
>    
>     The classes could be consumed by alternate implementations of jobs, like those in Hama BSP, but it would be risky to rely on them, as I never intended them to be part of the public API. That's why I put them in a util sub-package and called them inside the static configurator methods.
>    
>     The fact that they take the "implementingClass" parameter should also be an indicator they are internal helper code, and not public API.

Oh yeah, of course...I was confusing the methods on ConfiguratorBase with the similar ones that call them from the {Input,Output}Formats.

Do you think it's worth deprecating those methods on ConfiguratorBase anyway, or should I just drop the ones that are no longer used?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14972/#review28034
-----------------------------------------------------------
On Oct. 31, 2013, 2:35 p.m., John Vines wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14972/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 2:35 p.m.)
>
>
> Review request for accumulo and Michael Berman.
>
>
> Bugs: ACCUMULO-1009
>     https://issues.apache.org/jira/browse/ACCUMULO-1009
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Michael Berman's October 13 patch for ACCUMULO-1009
>
>
> Diffs
> -----
>
>   .gitignore 1ffa452
>   core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java 9247d56
>   core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java 5b5d041
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java bb5987d
>   core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java 32c80f9
>   core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java 218bd36
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java 0376304
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java 0dd86bf
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportKey.java f07139d
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportPool.java e7dabb5