Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Review Request 13122: PIG-3400 FS commands do not work with S3 paths


Copy link to this message
-
Re: Review Request 13122: PIG-3400 FS commands do not work with S3 paths
Getting rid of 2) may break existing user scripts. We can keep your s3 fix,
but can continue to not document it. Probably also add a deprecated note to
documentation, in the fs commands section saying cat, cd, ls, move, etc
commands now work even without specify fs, but that is deprecated and will
not be supported going forward and we recommend to switch to fs commands.

 Also, I see that those commands have been there from the very first
checkin. So let's wait for a response from Alan or Olga to understand why
we have those commands before we decide on deprecating or removing it.

Regards,
Rohini

On Wed, Jul 31, 2013 at 5:40 PM, Cheolsoo Park <[EMAIL PROTECTED]> wrote:

> Hi Aniket,
>
> >> fs commands were deprecated
>
> Are you referring 1) "fs -<command> <uri>" or 2) "<command> <uri>"? As of
> now, both exist, and 2) is not documented. I am +1 to removing 2) since
> it's totally duplicate. Maybe they're intentionally not documented. In
> fact, 1) already works fine with s3 paths.
>
> Shall we get rid of 2)?
>
> Thanks,
> Cheolsoo
>
>
>
>
> On Wed, Jul 31, 2013 at 1:01 PM, Aniket Mokashi <[EMAIL PROTECTED]>
> wrote:
>
> > I am not 100% sure but IIRC, fs commands were deprecated.
> >
> >
> > On Wed, Jul 31, 2013 at 12:37 PM, Cheolsoo Park <[EMAIL PROTECTED]
> >wrote:
> >
> >>
> >> -----------------------------------------------------------
> >>
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/13122/
> >> -----------------------------------------------------------
> >>
> >> Review request for pig.
> >>
> >>
> >> Bugs: PIG-3400
> >>     https://issues.apache.org/jira/browse/PIG-3400
> >>
> >>
> >> Repository: pig-git
> >>
> >>
> >> Description
> >> -------
> >>
> >>
> >> Makes fs utility commands work with s3 paths. Documents fs utility
> >> commands in the Pig manual. (They were not documented at all.)
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   src/docs/src/documentation/content/xdocs/cmds.xml 38babd2
> >>   src/org/apache/pig/tools/grunt/GruntParser.java c785084
> >>
> >> Diff: https://reviews.apache.org/r/13122/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >>
> >> All unit tests pass.
> >>
> >> Manually verified the following commands with s3 paths:
> >> pig -e 'ls s3://<path>'
> >> pig -e 'mkdir s3://<path>'
> >> pig -e 'rm s3://<path>'
> >> pig -e 'cp s3://<path1> s3://<path2>'
> >> pig -e 'mv s3://<path1> s3://<path2>'
> >> pig -e 'copyToLocal s3://<path>/<file> .'
> >> pig -e 'copyFromLocal <file> s3://<path>'
> >>
> >>
> >> Thanks,
> >>
> >> Cheolsoo Park
> >>
> >>
> >
> >
> > --
> > "...:::Aniket:::... Quetzalco@tl"
> >
>