Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 14576: NOT expression doesn't handle nulls correctly.


Copy link to this message
-
Review Request 14576: NOT expression doesn't handle nulls correctly.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14576/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-5430
    https://issues.apache.org/jira/browse/HIVE-5430
Repository: hive-git
Description
-------

NOT expression doesn't handle nulls correctly.
Diffs
-----

  ant/src/org/apache/hadoop/hive/ant/GenVectorTestCode.java 4065067
  ql/src/gen/vectorization/ExpressionTemplates/FilterScalarCompareColumn.txt 9a1d741
  ql/src/gen/vectorization/ExpressionTemplates/FilterStringScalarCompareColumn.txt 5ba7703
  ql/src/gen/vectorization/ExpressionTemplates/StringScalarCompareColumn.txt 635b3e6
  ql/src/gen/vectorization/TestTemplates/TestColumnScalarFilterVectorExpressionEvaluation.txt af30490
  ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java 54f2644
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionMappings.java PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 8f10644
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ConstantVectorExpression.java f464f04
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterExprAndExpr.java e6b511d
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterExprOrExpr.java 703096c
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterNotExpr.java cdf404c
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncLogWithBaseDoubleToDouble.java 214b6a5
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncLogWithBaseLongToDouble.java 42cb926
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncPowerDoubleToDouble.java dca4265
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncPowerLongToDouble.java 59e058c
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/RoundWithNumDigitsDoubleToDouble.java 54ffe69
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorFilterOperator.java c877cef
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 14b04c5
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorFilterExpressions.java 8321772
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorLogicalExpressions.java da67c63
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorMathFunctions.java 222d6b4
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java 28123a8
  ql/src/test/queries/clientpositive/vectorization_0.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_1.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_10.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_11.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_12.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_13.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_14.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_15.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_16.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_2.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_3.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_4.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_5.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_6.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_7.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_8.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_9.q PRE-CREATION
  ql/src/test/queries/clientpositive/vectorization_not.q PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_0.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_1.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_10.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_11.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_12.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_13.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_14.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_15.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_16.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_2.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_3.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_4.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_5.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_6.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_7.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_8.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_9.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_not.q.out PRE-CREATION

Diff: https://reviews.apache.org/r/14576/diff/
Testing
Thanks,

Jitendra Pandey