Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Zookeeper, mail # dev - Reviewboard, Gerrit was: ZooKeeper cleanup / refactoring / scala migration


Copy link to this message
-
Reviewboard, Gerrit was: ZooKeeper cleanup / refactoring / scala migration
Thomas Koch 2011-09-02, 19:48
Fournier, Camille F.:
> We already have a reviewboard set up for zookeeper which you should plan to

Hi Fournier,

I'll use reviewboard for patches targeted for inclusion. However just for
reference and to make you curious, I compare the steps necessary to create a
review in reviewboard and in gerrit:

reviewboard:
- create a patch file
- open web interface, log in
- select project
- select patch file
- select reviewer group
- select jira bug (lookup bug number in jira...)
- copy summary from jira issue (or write from scratch)
- enter "." for description
- publish

gerrit:
- include issue number in commit message
- git push gerrit
... That's it? That's it!

Additionally gerrit also triggers jenkins, merges the change in the master
branch once the review is finished and hosts your GIT repos with access
control. There's also inclusion in mylyn to let you do reviews from eclipse...
:-)

So if you like GIT you're invited to just play around with the gerrit
instance.

Best regards,

Thomas Koch, http://www.koch.ro