Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-997: Support secure transport mechanism


+
Joey Echeverria 2013-03-29, 12:44
+
Mike Percy 2013-04-15, 03:39
+
Joey Echeverria 2013-04-30, 15:02
+
Joey Echeverria 2013-04-30, 16:51
Copy link to this message
-
Re: Review Request: FLUME-997: Support secure transport mechanism
Joey Echeverria 2013-04-30, 17:01

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10190/
-----------------------------------------------------------

(Updated April 30, 2013, 5:01 p.m.)
Review request for Flume and Mike Percy.
Changes
-------

I updated the patch based on the feedback from the previous review.
Description
-------

The patch adds support for SSL to AvroSource and AvroSink. The implementation compliments the recent addition of compression in FLUME-1915.
This addresses bug FLUME-997.
    https://issues.apache.org/jira/browse/FLUME-997
Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 517d545
  flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java ac47ee9
  flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java c699241
  flume-ng-core/src/test/resources/server.p12 PRE-CREATION
  flume-ng-core/src/test/resources/truststore.jks PRE-CREATION
  flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205
  flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 8285129
  flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java 34d73a3

Diff: https://reviews.apache.org/r/10190/diff/
Testing
-------

There are tests for having SSL enabled on both the client and server with specific tests using a truststore to verify the server certificate. There's also a test to make sure you can enable both SSL and compression.

I probably need to add some negative tests:

1) SSL server, non-SSL client
2) SSL server, SSL client with a truststore that doesn't include the server certificate
Thanks,

Joey Echeverria

+
Mike Percy 2013-06-13, 05:27
+
Brock Noland 2013-03-29, 14:58
+
Joey Echeverria 2013-04-30, 16:52