Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 14240: SQOOP-1032: Add the --bulk-load-dir option to support the HBase doBulkLoad function


Copy link to this message
-
Re: Review Request 14240: SQOOP-1032: Add the --bulk-load-dir option to support the HBase doBulkLoad function
rj.vasanthkumar@... 2013-10-04, 09:45

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14240/#review26663
-----------------------------------------------------------

src/java/org/apache/sqoop/manager/SqlManager.java
<https://reviews.apache.org/r/14240/#comment51954>

    Suggestion: Can we move this option validation into BaseSqoopTool.validateHBaseOptions(...) ?

src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java
<https://reviews.apache.org/r/14240/#comment51950>

    "HBASE_USERNAME" variable is not used?

src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java
<https://reviews.apache.org/r/14240/#comment51951>

    Two spaces from line start

src/java/org/apache/sqoop/tool/BaseSqoopTool.java
<https://reviews.apache.org/r/14240/#comment51948>

    Suggestion: Can we have like "hbase-bulk-load-enabled" or "hbase-bulkload-enabled"? So this will be specific to hbase.

src/java/org/apache/sqoop/tool/BaseSqoopTool.java
<https://reviews.apache.org/r/14240/#comment51949>

    Suggestion: "Enables HBase bulk loading" ?
- vasanthkumar
On Oct. 2, 2013, 9:21 p.m., Alexandre Normand wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14240/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 9:21 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Jean-Marc Spaggiari, and vasanthkumar.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> This is the patch to address some of the comments on Zhancheng Deng's review request (https://reviews.apache.org/r/13052/) which was basically the change to add the --bulk-load-dir option to support the HBase doBulkLoad function.
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/SqoopOptions.java 01805f9
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 9ceb5bd
>   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 5ccf311
>   src/java/org/apache/sqoop/manager/SqlManager.java 2a4992d
>   src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java PRE-CREATION
>   src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java PRE-CREATION
>   src/java/org/apache/sqoop/mapreduce/ImportJobBase.java ab7f21e
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0eca991
>
> Diff: https://reviews.apache.org/r/14240/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexandre Normand
>
>