Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-959 Use CredentialsUtil.fetchPasswordFromFile in BaseSqoopTool


+
Jarek Cecho 2013-03-20, 19:35
Copy link to this message
-
Re: Review Request: SQOOP-959 Use CredentialsUtil.fetchPasswordFromFile in BaseSqoopTool

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10049/#review18171
-----------------------------------------------------------

Ship it!
+1. Looks good. My bad that you had to clean up.

- Seetharam Venkatesh
On March 20, 2013, 7:35 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10049/
> -----------------------------------------------------------
>
> (Updated March 20, 2013, 7:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've removed the extra method in BaseSqoopTool.
>
>
> This addresses bug SQOOP-959.
>     https://issues.apache.org/jira/browse/SQOOP-959
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java e687137d2ac7d6527c81a197b1277108a416bea6
>
> Diff: https://reviews.apache.org/r/10049/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've test it on real cluster as well.
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Kathleen Ting 2013-03-21, 16:32
+
Kathleen Ting 2013-03-21, 16:32