Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Re: Review Request 15881: PIG-3591: Refactor POPackage


Copy link to this message
-
Re: Review Request 15881: PIG-3591: Refactor POPackage

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15881/#review36273
I am still going over the main classes POPackage and Packager implementations. Just going over thoroughly to ensure no piece of code is missed out in the refactor. Will update any comments on that tomorrow.
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MRCompiler.java
<https://reviews.apache.org/r/15881/#comment67229>

    I believe this check should not be removed

src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PlanPrinter.java
<https://reviews.apache.org/r/15881/#comment67257>

    Don't we still need this? i.e Print out the list of packagers MultiQueryPackager has.

src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/XMLPhysicalPlanPrinter.java
<https://reviews.apache.org/r/15881/#comment67259>

    Don't we still need this?

src/org/apache/pig/pen/IllustratorAttacher.java
<https://reviews.apache.org/r/15881/#comment67304>

    Don't we need the equivalent of this code in visitPackage?
- Rohini Palaniswamy
On March 4, 2014, 9:40 p.m., Mark Wagner wrote: