Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Review Request 17876: [PIG-3456] Reduce threadlocal conf access in backend for each record


Copy link to this message
-
Re: Review Request 17876: [PIG-3456] Reduce threadlocal conf access in backend for each record
Dmitriy Ryaboy 2014-02-10, 04:00

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17876/#review34044

http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigGenericMapBase.java
<https://reviews.apache.org/r/17876/#comment63999>

    This is problematic style -- an undocumented implicit contract on mp.isEmpty() not changing after setup(), and the variable is private, so none of the implementors or this abstract class can do anything about its value.

http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPackage.java
<https://reviews.apache.org/r/17876/#comment63998>

    outside the scope of this patch, but what's our story with sJobConfInternal? It's internal, but marked public, and plain old sJobConf is deprecated in favor of UdfContext.getUdfContext().getJobConf()
    
    we should at least have a comment in that code explaining what's going on and when you would use which...

http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPackage.java
<https://reviews.apache.org/r/17876/#comment63997>

    let's move these string constants (batchsize, cachedbag type, etc) to PigConfiguration when we come across them
- Dmitriy Ryaboy
On Feb. 9, 2014, 2:17 a.m., Rohini Palaniswamy wrote: