Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Re: Review Request 18607: PIG-3784: Port more mini cluster tests to Tez


Copy link to this message
-
Re: Review Request 18607: PIG-3784: Port more mini cluster tests to Tez

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18607/#review35838

test/org/apache/pig/test/TestEvalPipeline.java
<https://reviews.apache.org/r/18607/#comment66609>

    Are the double changes in multiple places needed?

test/org/apache/pig/test/TestPigServer.java
<https://reviews.apache.org/r/18607/#comment66622>

    Can we do this in PigServer.java instead of nullifying in each test?
    
    -        if (PigStats.get() == null) {
    -            PigStats.start(pigContext.getExecutionEngine().instantiatePigStats());
    -        }
    -
    -        if (ScriptState.get() == null) {
    -            ScriptState.start(pigContext.getExecutionEngine().instantiateScriptState());
    -        }
    +        PigStats.start(pigContext.getExecutionEngine().instantiatePigStats());
    +        ScriptState.start(pigContext.getExecutionEngine().instantiateScriptState());
- Rohini Palaniswamy
On Feb. 28, 2014, 4:07 a.m., Cheolsoo Park wrote: