-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9070/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've improved the validator and move there some logic that was in initializer.
This addresses bug SQOOP-845.
    https://issues.apache.org/jira/browse/SQOOP-845
Diffs
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 531dd2e9b7215bd1d3825fe7018b10d32e774db5
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java c6336fabbdc2074206c31c541c5dfc2c0cb3d908
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 5ba1aae12e457c70e2b8fdc6d530a8ee0b8be421

Diff: https://reviews.apache.org/r/9070/diff/
Testing
-------

Unit tests seems to be passing and I tried simple import on real cluster.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9070/#review15897
-----------------------------------------------------------
Looks good overall. I have suggestions regarding error messages as below.

Also, I was wondering if you could use constant string variables instead of duplicate strings at multiple places. Just a suggestion, and I won't insist.
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
<https://reviews.apache.org/r/9070/#comment34170>

    Can you change the message to something like "Either table name or SQL must be specified"?

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
<https://reviews.apache.org/r/9070/#comment34171>

    Can you change the message to something like "Both table name and SQL cannot be specified"?

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
<https://reviews.apache.org/r/9070/#comment34172>

    Same as above.

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
<https://reviews.apache.org/r/9070/#comment34173>

    Same as above.
- Cheolsoo Park
On Jan. 23, 2013, 6:45 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9070/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 6:45 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've improved the validator and move there some logic that was in initializer.
>
>
> This addresses bug SQOOP-845.
>     https://issues.apache.org/jira/browse/SQOOP-845
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 531dd2e9b7215bd1d3825fe7018b10d32e774db5
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java c6336fabbdc2074206c31c541c5dfc2c0cb3d908
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 5ba1aae12e457c70e2b8fdc6d530a8ee0b8be421
>
> Diff: https://reviews.apache.org/r/9070/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I tried simple import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

> On Jan. 30, 2013, 11:22 p.m., Cheolsoo Park wrote:
> > Looks good overall. I have suggestions regarding error messages as below.
> >
> > Also, I was wondering if you could use constant string variables instead of duplicate strings at multiple places. Just a suggestion, and I won't insist.

Hi Cheolsoo,
thank you very much for your review!

I'm hoping that the duplicate strings will be removed very soon by including SQOOP-858, so I would let it be for now.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9070/#review15897
-----------------------------------------------------------
On Jan. 23, 2013, 6:45 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9070/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 6:45 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've improved the validator and move there some logic that was in initializer.
>
>
> This addresses bug SQOOP-845.
>     https://issues.apache.org/jira/browse/SQOOP-845
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 531dd2e9b7215bd1d3825fe7018b10d32e774db5
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java c6336fabbdc2074206c31c541c5dfc2c0cb3d908
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 5ba1aae12e457c70e2b8fdc6d530a8ee0b8be421
>
> Diff: https://reviews.apache.org/r/9070/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I tried simple import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9070/
-----------------------------------------------------------

(Updated Jan. 31, 2013, 4:37 p.m.)
Review request for Sqoop.
Changes
-------

I've incorporated Cheolsoo's suggestions.
Description
-------

I've improved the validator and move there some logic that was in initializer.
This addresses bug SQOOP-845.
    https://issues.apache.org/jira/browse/SQOOP-845
Diffs (updated)
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 531dd2e9b7215bd1d3825fe7018b10d32e774db5
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java c6336fabbdc2074206c31c541c5dfc2c0cb3d908
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 5ba1aae12e457c70e2b8fdc6d530a8ee0b8be421

Diff: https://reviews.apache.org/r/9070/diff/
Testing
-------

Unit tests seems to be passing and I tried simple import on real cluster.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9070/#review15943
-----------------------------------------------------------

Ship it!
Thanks Jarcec!

- Cheolsoo Park
On Jan. 31, 2013, 4:37 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9070/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 4:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've improved the validator and move there some logic that was in initializer.
>
>
> This addresses bug SQOOP-845.
>     https://issues.apache.org/jira/browse/SQOOP-845
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 531dd2e9b7215bd1d3825fe7018b10d32e774db5
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java c6336fabbdc2074206c31c541c5dfc2c0cb3d908
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 5ba1aae12e457c70e2b8fdc6d530a8ee0b8be421
>
> Diff: https://reviews.apache.org/r/9070/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I tried simple import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>