Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request 12803: Fix for Flume-2109, Take 3. Incorporated Review comments and implementation in sysc with Avro source


Copy link to this message
-
Re: Review Request 12803: Fix for Flume-2109, Take 3. Incorporated Review comments and implementation in sysc with Avro source

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12803/#review24484
-----------------------------------------------------------
Ashish,

This looks ready to commit. I have a couple of requests - if you want me to commit this one, and complete the test in a follow-up jira, that is fine by me too.
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java
<https://reviews.apache.org/r/12803/#comment48424>

    We should probably log this at INFO level.

flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java
<https://reviews.apache.org/r/12803/#comment48428>

    Can you add one test where a non-SSL connection fails?
- Hari Shreedharan
On July 22, 2013, 7:56 a.m., Ashish Paliwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12803/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 7:56 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2109
>     https://issues.apache.org/jira/browse/FLUME-2109
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Fix for Flume-2109, to support HTTPS.
> Incorporates Review comments from Alex
> Implementation refined to be as close to Avro Source, like SSL port is not to be defined, the port value shall be used
> Documentation updated to reflect the changes
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java c90f067
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java f547e0f
>   flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 8952db3
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 63cad21
>
> Diff: https://reviews.apache.org/r/12803/diff/
>
>
> Testing
> -------
>
> Unit Test case written to test SSL functionality
>
>
> Thanks,
>
> Ashish Paliwal
>
>