Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
HBase, mail # dev - Re: Review Request: HBASE-2223


+
Jean-Daniel Cryans 2010-05-27, 01:09
+
Benoit Sigoure 2010-05-27, 06:48
+
Jean-Daniel Cryans 2010-05-28, 00:19
Copy link to this message
-
Re: Review Request: HBASE-2223
Benoit Sigoure 2010-05-27, 19:55

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/76/#review86
-----------------------------------------------------------

src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
<http://review.hbase.org/r/76/#comment472>

    This test is pretty long and tests quite a few different things.  Consider to break it down into multiple smaller unit tests.

src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
<http://review.hbase.org/r/76/#comment473>

    I'm not sure to understand why this test is named like that.  Could you comment this test a bit more to explain what the intent is?

src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
<http://review.hbase.org/r/76/#comment474>

    This seems brittle to me.

src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
<http://review.hbase.org/r/76/#comment475>

    ?

src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
<http://review.hbase.org/r/76/#comment476>

    I believe this method can be made `static'.

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment477>

    Copyright header.

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment486>

    I'm not a big fan of this.

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment478>

    private.

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment479>

    Do you really need to define the 3 following empty methods?

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment484>

    Consider writing a comment explaining what this test does.

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment480>

    Missing space before `conf'.

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment481>

    +"" is an idiom I don't like.

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment482>

    Missing spaces.

src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
<http://review.hbase.org/r/76/#comment483>

    Missing spaces.

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
<http://review.hbase.org/r/76/#comment485>

    Don't do this.

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
<http://review.hbase.org/r/76/#comment487>

    Don't do this.

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
<http://review.hbase.org/r/76/#comment488>

    Why protected?

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
<http://review.hbase.org/r/76/#comment489>

    Is this really needed?

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
<http://review.hbase.org/r/76/#comment490>

    I don't understand why you're doing +=2 and /2 instead of just setting the upper bound of the loop to BATCH_SIZE/2.

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
<http://review.hbase.org/r/76/#comment491>

    Missing space before `scanRes'.

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
<http://review.hbase.org/r/76/#comment492>

    Why protected?

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
<http://review.hbase.org/r/76/#comment493>

    ?

src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
<http://review.hbase.org/r/76/#comment494>

    Uh?  Manual loop unrolling?
- Benoit
On 2010-05-26 18:09:30, Jean-Daniel Cryans wrote:
+
Jean-Daniel Cryans 2010-05-28, 18:55
+
Jean-Daniel Cryans 2010-05-28, 19:03
+
Jean-Daniel Cryans 2010-05-28, 23:02
+
Jean-Daniel Cryans 2010-06-17, 19:57
+
Jean-Daniel Cryans 2010-06-24, 00:24
+
Jean-Daniel Cryans 2010-06-30, 22:36
+
stack@... 2010-06-30, 22:39
+
stack@... 2010-06-25, 22:07
+
Jean-Daniel Cryans 2010-06-29, 01:29