Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: Ability to specify the capacity of MemoryChannel in bytes


+
Ted Malaska 2012-09-10, 13:59
+
Mike Percy 2012-09-14, 06:14
+
Ted Malaska 2012-09-14, 14:00
+
Mike Percy 2012-09-14, 20:44
+
Ted Malaska 2012-09-14, 20:45
+
Ted Malaska 2012-09-14, 20:48
+
Ted Malaska 2012-09-14, 21:14
+
Hari Shreedharan 2012-09-15, 21:21
Copy link to this message
-
Re: Review Request: Ability to specify the capacity of MemoryChannel in bytes


> On Sept. 14, 2012, 8:44 p.m., Mike Percy wrote:
> > We need to find another way to do it than make it synchronized. That would kill multithreaded performance.
>
> Ted Malaska wrote:
>     You mean on the put?  Hmm let me think about it
>
> Ted Malaska wrote:
>     How about a on the first if statement getAndAdd(+eventSize) and a getAndAdd(-eventSize) if the event doesn't get into the queue?
>
> Ted Malaska wrote:
>     Talked with Mike
>    
>     Here is the plan for the weekend
>     1. Change the put logic to not use sync but a getAndAdd(+EventSize) at the time of if and getAndAdd(-eventSize_ if there is a failure getting into the queue
>     2. Single a log.info if config doesn't have memory limit set.
>
> Hari Shreedharan wrote:
>     Suggestion: You could use a semaphore to keep track of the bytes used/available. A semaphore can go up only to about 1.5G(since it uses integer). You could definite granularity limit of 10 bytes or so(1 permit on the semaphore buys 10 bytes - so a 50 byte event requires 5 permits(+ calculate object overheads), to increase this to 15G - which seems reasonable.

Thanks Hari,

I've never used Semaphore, but they look really cool.  I don't know if I like the 15G limit. hmm.  Let me finish 1295 then I'm start playing with both ideas.
- Ted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6982/#review11563
-----------------------------------------------------------
On Sept. 14, 2012, 2 p.m., Ted Malaska wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6982/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2012, 2 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> 1. The user will be able to define a byteCapacity and a byteCapacityBufferPercentage.
> 2. Events byte size will be estimated from there body contents
> 3. On put bytes are added to current total
> 4. On commit any uncommitted takes are removed from the current byte total
> 5. On rollover any uncommitted puts are removed from the current byte total
>
>
> This addresses bug FLUME-1535.
>     https://issues.apache.org/jira/browse/FLUME-1535
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java c72e97c
>   flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e070864
>
> Diff: https://reviews.apache.org/r/6982/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ted Malaska
>
>

+
Hari Shreedharan 2012-09-15, 22:31
+
Ted Malaska 2012-09-16, 03:47
+
Ted Malaska 2012-09-19, 15:28
+
Ted Malaska 2012-09-16, 03:54
+
Hari Shreedharan 2012-10-01, 20:30
+
Hari Shreedharan 2012-10-01, 20:32
+
Hari Shreedharan 2012-10-01, 20:51
+
Ted Malaska 2012-10-02, 00:43
+
Hari Shreedharan 2012-10-02, 00:48
+
Hari Shreedharan 2012-10-02, 00:50
+
Ted Malaska 2012-10-02, 11:31
+
Hari Shreedharan 2012-10-02, 17:36
+
Hari Shreedharan 2012-10-02, 21:07
+
Ted Malaska 2012-10-03, 00:39
+
Ted Malaska 2012-10-03, 10:37
+
Ted Malaska 2012-10-04, 03:33
+
Ted Malaska 2012-10-04, 11:44
+
Ted Malaska 2012-10-04, 11:45
+
Ted Malaska 2012-10-04, 11:52
+
Hari Shreedharan 2012-10-04, 19:16
+
Ted Malaska 2012-10-04, 23:47
+
Ted Malaska 2012-10-04, 23:47
+
Ted Malaska 2012-10-05, 11:55
+
Hari Shreedharan 2012-10-05, 22:23