Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly


+
Jarek Cecho 2013-01-06, 17:58
Copy link to this message
-
Re: Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly
Jarek Cecho 2013-01-23, 00:29

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8848/
-----------------------------------------------------------

(Updated Jan. 23, 2013, 12:29 a.m.)
Review request for Sqoop.
Changes
-------

I've incorporated Cheolsoo's comments.
Description
-------

I've fix methods toJson and fillValues() to work with new schema of configuration objects.
This addresses bug SQOOP-812.
    https://issues.apache.org/jira/browse/SQOOP-812
Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02eee14a004df45d6fa77dcde4bd65132088
  common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45947a364e9002db0e7ff0a2603ba75263d

Diff: https://reviews.apache.org/r/8848/diff/
Testing
-------

I've added new unit test.
Thanks,

Jarek Cecho

+
Cheolsoo Park 2013-01-23, 00:35
+
Cheolsoo Park 2013-01-22, 23:51
+
Jarek Cecho 2013-01-23, 00:29