Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Re: Review Request 11783: DRILL-45: Add builders for PlanProperties, LogicalPlan, Store and Scan


Copy link to this message
-
Re: Review Request 11783: DRILL-45: Add builders for PlanProperties, LogicalPlan, Store and Scan
Ben Becker 2013-10-30, 23:16

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11783/
-----------------------------------------------------------

(Updated Oct. 30, 2013, 11:16 p.m.)
Review request for drill and Jacques Nadeau.
Changes
-------

Rebased onto latest master.

GitHub branch: https://github.com/vrtx/incubator-drill/tree/DRILL-45-commit
JIRA: https://issues.apache.org/jira/browse/DRILL-45 (latest 'DRILL-45.patch' attachment)
Repository: drill-git
Description
-------

Looking for validation of builder apprach.
 - Includes LogicalPlanBuilder and PlanPropertiesBuilder attached to JIRA-45; rebased to latest execwork.
 - Includes ScanBuilder and StoreBuilder as well.

Note: One of the original builders also had a 'toBuilder()' method.  Is that something we should add for all builders?
Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/PlanProperties.java 637dd66
  common/src/main/java/org/apache/drill/common/logical/LogicalPlan.java 868f9ba
  common/src/main/java/org/apache/drill/common/logical/LogicalPlanBuilder.java PRE-CREATION
  common/src/main/java/org/apache/drill/common/logical/PlanProperties.java PRE-CREATION
  common/src/main/java/org/apache/drill/common/logical/data/Scan.java 9c315ff
  common/src/main/java/org/apache/drill/common/logical/data/ScanBuilder.java PRE-CREATION
  common/src/main/java/org/apache/drill/common/logical/data/Store.java bc34cc7
  common/src/main/java/org/apache/drill/common/logical/data/StoreBuilder.java PRE-CREATION
  common/src/test/resources/storage_engine_plan.json efde80d
  exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java c09af88
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/PhysicalPlan.java 7349dad
  sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/LogicalPlanBuilderTest.java PRE-CREATION
  sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/ScanBuilderTest.java PRE-CREATION
  sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/StoreBuilderTest.java PRE-CREATION
  sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcTest.java 7574c2c

Diff: https://reviews.apache.org/r/11783/diff/
Testing
-------
Thanks,

Ben Becker