Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-629: Provide better exception handling during server-client communication


Copy link to this message
-
Re: Review Request: SQOOP-629: Provide better exception handling during server-client communication

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7624/#review12514
-----------------------------------------------------------
Look good overall.  TestThrowableBean.java is missing a license header though.  Could you add that and upload a new patch to JIRA?  Thanks.

- Bilung Lee
On Oct. 16, 2012, 11:22 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7624/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2012, 11:22 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've implemented ThrowableBean that transfers entire bean, including stack trace and all "caused by" exceptions. I've provided pretty printing functionality on the client side to have "nice output".
>
>
> This addresses bug SQOOP-629.
>     https://issues.apache.org/jira/browse/SQOOP-629
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/ClientError.java 1cf42e470021fc42c33c4cd4165f508bd4ec1ecf
>   client/src/main/java/org/apache/sqoop/client/request/Request.java 5e381c99b72aecd07f26c1f6b8fe052c1be6a962
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java 1ea773b06ba3ead84cbf70c7adc6be2185944483
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java c610fd47f198a082e829763988480bdfd79a67dc
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java d2b56ba2dca2462ca6d28d0f8c58528240ff9d78
>   client/src/main/java/org/apache/sqoop/client/utils/ThrowableDisplayer.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/json/ExceptionInfo.java 68de4b1b743d94ab81664f548d8ce2ec98e8c6b1
>   common/src/main/java/org/apache/sqoop/json/ThrowableBean.java PRE-CREATION
>   common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java PRE-CREATION
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java e3bf0e1dc8fafc06368cf64310ba1c4abb3015f7
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 81044ce7d8a014efac0281f79a7c97ab37ca42ae
>   server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java ece3d93653831cb83dc4c517e8331e516e0624d1
>   server/src/main/java/org/apache/sqoop/server/common/ServerError.java 0a97d2d171023518abc084412ccc8c6394ea251c
>
> Diff: https://reviews.apache.org/r/7624/diff/
>
>
> Testing
> -------
>
> I've provided unit tests for new functionality and I've also tested it manually.
>
>
> Thanks,
>
> Jarek Cecho
>
>