Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: Fix for TestFlumeEventQueue failures in FileChannel on Windows


Copy link to this message
-
Review Request: Fix for TestFlumeEventQueue failures in FileChannel on Windows

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11536/
-----------------------------------------------------------

Review request for Flume.
Description
-------

Windows does not allow deletion of files that are in use. Java does not yet allow explicitly unmapping memory mapped files so until these files are unmapped by the GC, we cannot delete them explicitly.

Checkpoint files are being reused across tests. Deletion of checkpoint files fails in these tests as the file memory mapped.

Fix: Not reusing checkpoint files to avoid deletion problems. Also ensuring files are setup to be deleted by jvm on exit.
This addresses bug FLUME-2058.
    https://issues.apache.org/jira/browse/FLUME-2058
Diffs
-----

  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFlumeEventQueue.java 203cbf2

Diff: https://reviews.apache.org/r/11536/diff/
Testing
-------

TestFlumeEventQueue test now pass on Windows.
Thanks,

Roshan Naik

+
Hari Shreedharan 2013-06-18, 23:51
+
Mike Percy 2013-06-21, 21:11