Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2


Copy link to this message
-
Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13845/#review26525
-----------------------------------------------------------
Here's what I caught on a first pass.
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
<https://reviews.apache.org/r/13845/#comment51748>

    TAB

common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/13845/#comment57262>

    hive-default.xml.template?

itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java
<https://reviews.apache.org/r/13845/#comment57263>

    Formatting.

service/if/TCLIService.thrift
<https://reviews.apache.org/r/13845/#comment57259>

    Please leave a blank line between message fields with comments.

service/if/TCLIService.thrift
<https://reviews.apache.org/r/13845/#comment57260>

    Comment out of sync with code.

service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
<https://reviews.apache.org/r/13845/#comment57264>

    Why is CLIService.getDelegationToken() allowed to return a null or empty string?

service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
<https://reviews.apache.org/r/13845/#comment57265>

    Formatting.
- Carl Steinbach
On Dec. 4, 2013, 8:13 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13845/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 8:13 p.m.)
>
>
> Review request for hive, Brock Noland, Carl Steinbach, and Thejas Nair.
>
>
> Bugs: HIVE-5155
>     https://issues.apache.org/jira/browse/HIVE-5155
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Delegation token support -
> Enable delegation token connection for HiveServer2
> Enhance the TCLIService interface to support delegation token requests
> Support passing the delegation token connection type via JDBC URL and Beeline option
>
> Direct proxy access -
> Define new proxy user property
> Shim interfaces to validate proxy access for a given user
>
> Note that the diff doesn't include thrift generated code.
>
>
> Diffs
> -----
>
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java c5e36a5
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c3abba3
>   beeline/src/java/org/apache/hive/beeline/Commands.java d2d7fd3
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 1de5829
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 36503fa
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 7b1c9da
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573
>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 4d75d98
>   service/if/TCLIService.thrift 62a9730
>   service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java d80649f
>   service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java 519556c
>   service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java 15b1675
>   service/src/java/org/apache/hive/service/cli/CLIService.java 8c85386
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 14ef54f
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9dca874
>   service/src/java/org/apache/hive/service/cli/ICLIService.java f647ce6
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 00058cc
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cfda752
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 708f4e4
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java e262b72
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 9df110e
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 9bb2a0f