Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Sqoop2: Move string constants from FormDisplayer to resource file


Copy link to this message
-
Re: Review Request: Sqoop2: Move string constants from FormDisplayer to resource file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/#review17679
-----------------------------------------------------------
Hi Vasanth,
would you mind rebasing your changes with current changes in head of the sqoop2 branch? I'll be happy to help or to take it from here if you're not interested any more.

Jarcec

- Jarek Cecho
On Feb. 28, 2013, 3:04 a.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9669/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 3:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Move string constants from FormDisplayer to resource file
>
>
> This addresses bug SQOOP-887.
>     https://issues.apache.org/jira/browse/SQOOP-887
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java af325d5
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java c2464d2
>   client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java 31de8dc
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 0d67133
>   client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java 4d0442f
>   client/src/main/resources/client-resource.properties 58cfe55
>
> Diff: https://reviews.apache.org/r/9669/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>