Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-901 Allow user to override hardcoded boolean strings in direct PostgreSQL connector


Copy link to this message
-
Re: Review Request: SQOOP-901 Allow user to override hardcoded boolean strings in direct PostgreSQL connector
Jarek Cecho 2013-02-23, 17:39

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9488/
-----------------------------------------------------------

(Updated Feb. 23, 2013, 5:39 p.m.)
Review request for Sqoop.
Changes
-------

I've incorporated Cheolsoo's feedback.
Description
-------

I've provided extra options that will override the build-in defaults if needed.
This addresses bug SQOOP-901.
    https://issues.apache.org/jira/browse/SQOOP-901
Diffs (updated)
-----

  src/docs/user/connectors.txt ff424f74b826beb4e9ea3ccd5822cbcac5ce2026
  src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java a05bf606dbc61cfab4fc977fa1f51feb59c5e446
  src/java/org/apache/sqoop/manager/PostgresqlManager.java facdc742f9bc2470b89b5bcac8b210bef84d7349
  src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java ee00c4124b0a24fdc99142005be2f0b2d404d030

Diff: https://reviews.apache.org/r/9488/diff/
Testing
-------

New unit test provided.
Thanks,

Jarek Cecho