Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: BasicTransactionSemantics should avoid throw-ing from close()


+
Roshan Naik 2013-04-09, 03:21
+
Mike Percy 2013-04-16, 22:51
+
Mike Percy 2013-04-16, 22:52
+
Roshan Naik 2013-04-17, 00:44
+
Mike Percy 2013-04-17, 20:39
+
Brock Noland 2013-04-09, 20:31
Copy link to this message
-
Re: Review Request: BasicTransactionSemantics should avoid throw-ing from close()
Hari Shreedharan 2013-04-09, 20:46

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10362/#review18884
-----------------------------------------------------------

flume-ng-core/src/main/java/org/apache/flume/channel/BasicTransactionSemantics.java
<https://reviews.apache.org/r/10362/#comment39340>

    I agree with Brock. This should not be the case. The file channel can lose data if we don't rollback (unless there is a replay)
- Hari Shreedharan
On April 9, 2013, 3:21 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10362/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 3:21 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Loggin error instead of throwing exception in cases where close() is called w/o rollback or abort being called.
>
>
> This addresses bug FLUME-1321.
>     https://issues.apache.org/jira/browse/FLUME-1321
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/channel/BasicTransactionSemantics.java 403cbca
>
> Diff: https://reviews.apache.org/r/10362/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roshan Naik
>
>

+
Brock Noland 2013-04-09, 20:54
+
Roshan Naik 2013-04-09, 23:52
+
Brock Noland 2013-04-10, 18:19
+
Roshan Naik 2013-04-10, 18:28
+
Brock Noland 2013-04-10, 18:53
+
Brock Noland 2013-04-10, 19:09