Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-430: Duplicate Column problem with reserved words


Copy link to this message
-
Re: Review Request: SQOOP-430: Duplicate Column problem with reserved words
Bilung Lee 2012-01-25, 22:08

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3581/#review4607
-----------------------------------------------------------

Ship it!
Thanks for the quick update!

- Bilung
On 2012-01-25 22:01:34, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3581/
> -----------------------------------------------------------
>
> (Updated 2012-01-25 22:01:34)
>
>
> Review request for Sqoop and Bilung Lee.
>
>
> Summary
> -------
>
> I've just tweak code generation to support use case mentioned in the JIRA - case when both keyword and _keyword columns are present in the same table. Current code generation code might create many other duplicates because of dropping  of unsupported characters and other transformations. Those advanced problems might be solved by --query and SQL projections ('column!' AS column2, 'column?' as column3).
>
>
> This addresses bug SQOOP-430.
>     https://issues.apache.org/jira/browse/SQOOP-430
>
>
> Diffs
> -----
>
>   /src/java/org/apache/sqoop/orm/ClassWriter.java 1235863
>   /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1235863
>
> Diff: https://reviews.apache.org/r/3581/diff
>
>
> Testing
> -------
>
> All tests pass for both hadoopversion=20 and hadoopversion=23.
>
>
> Thanks,
>
> Jarek
>
>