Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig, mail # dev - Review Request 17087: PIG-2207 Support custom counters for aggregating warnings from different udfs


+
Aniket Mokashi 2014-01-18, 03:52
+
Aniket Mokashi 2014-01-22, 19:24
+
Aniket Mokashi 2014-01-22, 19:24
+
Aniket Mokashi 2014-01-22, 23:53
+
Aniket Mokashi 2014-01-22, 23:54
+
Daniel Dai 2014-01-23, 00:34
+
Daniel Dai 2014-01-22, 21:43
Copy link to this message
-
Re: Review Request 17087: PIG-2207 Support custom counters for aggregating warnings from different udfs
Daniel Dai 2014-01-22, 23:43


> On Jan. 22, 2014, 9:43 p.m., Daniel Dai wrote:
> > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java, line 68
> > <https://reviews.apache.org/r/17087/diff/1/?file=429825#file429825line68>
> >
> >     New LoadFunc/StoreFunc might use it, right?
>
> Aniket Mokashi wrote:
>     I mean, LoadFunc/StoreFunc does not currently use PigHadoopLogger. We can do another jira to fix that.
>
> Daniel Dai wrote:
>     What I mean is if tomorrow a LoadFunc decide to use counter, if he choose to use PigHadoopLogger.warn, should it behave the same as EvalFunc?
>
> Aniket Mokashi wrote:
>     So, your point is since its a singleton, its possible for LoadFunc's to PigHadoopLogger.getInstance().warn and make use of this api. I agree to your point, let me add this to the code.
>    
>     By the way, LoadFunc has "public final void warn(String msg, Enum warningEnum)" that does report aggregated warnings but not through this api. I'm not sure why we did not use this api. Any thoughts?

Not sure why, but make EvalFunc standout seems not right to me in your method.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17087/#review32558
-----------------------------------------------------------
On Jan. 22, 2014, 7:24 p.m., Aniket Mokashi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17087/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 7:24 p.m.)
>
>
> Review request for pig, Cheolsoo Park, Daniel Dai, and Thejas Nair.
>
>
> Bugs: PIG-2207
>     https://issues.apache.org/jira/browse/PIG-2207
>
>
> Repository: pig-git
>
>
> Description
> -------
>
> - Grouped counters for udfs
> - Log at least once.
>
>
> Diffs
> -----
>
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java 6842b10
>
> Diff: https://reviews.apache.org/r/17087/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aniket Mokashi
>
>

+
Aniket Mokashi 2014-01-22, 23:45
+
Aniket Mokashi 2014-01-22, 23:35
+
Daniel Dai 2014-01-22, 23:13
+
Aniket Mokashi 2014-01-22, 23:10
+
Daniel Dai 2014-01-22, 20:22
+
Aniket Mokashi 2014-01-22, 21:22