Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Bigtop >> mail # dev >> Review Request 12526: BIGTOP-939. Make usage of bigtop-tomcat more dynamic


Copy link to this message
-
Re: Review Request 12526: BIGTOP-939. Make usage of bigtop-tomcat more dynamic

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12526/#review23105
-----------------------------------------------------------

bigtop-packages/src/common/hadoop/install_hadoop.sh
<https://reviews.apache.org/r/12526/#comment46932>

    Should this be
    chmod 644 $HTTPFS_ETC_DIR/conf.empty/tomcat-deployment/conf/*?

bigtop-packages/src/common/oozie/install_oozie.sh
<https://reviews.apache.org/r/12526/#comment46937>

    The old code shows that we need to change 2 xml files for ssl configuration - web.xml and server.xml.
    
    You only seem to be changing web.xml. Should we change server.xml as well here (you seem to be changing that in the init script)?

bigtop-packages/src/common/oozie/install_oozie.sh
<https://reviews.apache.org/r/12526/#comment46941>

    Should we have a default webapps symlink (pointing to the non-SSL configuration) out of the box? It would get copied over when we do cp -r in the init script.

bigtop-packages/src/common/oozie/oozie.init
<https://reviews.apache.org/r/12526/#comment46945>

    I think we should forcefully remove the symlink to be on the safe side before we create it. Alternatively, we can force create the symlink, overriding the previous symlink.

bigtop-packages/src/common/oozie/oozie.init
<https://reviews.apache.org/r/12526/#comment46948>

    Ok, so how does this work if someone wants to use their own custom configuration for oozie? Historically, we have provided that option so all users have to do is to update the alternatives symlink to their own custom config directory but this doesn't seem to be in line with that.

bigtop-packages/src/common/sqoop/sqoop-server.sh
<https://reviews.apache.org/r/12526/#comment46965>

    extra prepending slash before ${DEPLOYMENT_TARGET}?
- Mark Grover
On July 12, 2013, 10:16 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12526/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:16 p.m.)
>
>
> Review request for bigtop and Mark Grover.
>
>
> Bugs: BIGTOP-939
>     https://issues.apache.org/jira/browse/BIGTOP-939
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> Explained on JIRA - uploaded here only for commenting convenience.
>
>
> Diffs
> -----
>
>   bigtop-packages/src/common/hadoop/hadoop-httpfs.svc de4d6d2
>   bigtop-packages/src/common/hadoop/httpfs.default e48e608
>   bigtop-packages/src/common/hadoop/install_hadoop.sh ed9cb5c
>   bigtop-packages/src/common/oozie/install_oozie.sh c27dd64
>   bigtop-packages/src/common/oozie/oozie-env.sh dd051f7
>   bigtop-packages/src/common/oozie/oozie.init 4600841
>   bigtop-packages/src/common/solr/install_solr.sh 4e09e40
>   bigtop-packages/src/common/solr/solr-server.init.debian 5b8b862
>   bigtop-packages/src/common/sqoop/install_sqoop.sh df4f489
>   bigtop-packages/src/common/sqoop/sqoop-server.sh b1de301
>   bigtop-packages/src/common/sqoop/sqoop.default cdec81c
>   bigtop-packages/src/common/sqoop/sqoop.sh afe1ac6
>   bigtop-packages/src/deb/hadoop/hadoop-httpfs.install fe1a462
>   bigtop-packages/src/deb/sqoop/sqoop.install 0386c7a
>   bigtop-packages/src/rpm/hadoop/SPECS/hadoop.spec acfc2fa
>   bigtop-packages/src/rpm/oozie/SPECS/oozie.spec 4bbc212
>   bigtop-packages/src/rpm/solr/SOURCES/solr-server.init 6d1a035
>   bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 5f4447b
>
> Diff: https://reviews.apache.org/r/12526/diff/
>
>
> Testing
> -------
>
> Explained on JIRA - uploaded here only for commenting convenience.
>
>
> Thanks,
>
> Sean Mackrory
>
>