-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6356/
-----------------------------------------------------------

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Description
-------

I've implemented split of framework and connector specific metadata:

* Framework metadata consists only from set of connection and job forms
* I've refined Repository and JdbcRepositoryHandler to deal with new framework metadata
* I've provide implementation for build in Derby metastore
This addresses bug SQOOP-535.
    https://issues.apache.org/jira/browse/SQOOP-535
Diffs
-----

  /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnector.java 1368756
  /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MFramework.java PRE-CREATION
  /branches/sqoop2/common/src/test/java/org/apache/sqoop/model/TestMPersistableEntity.java 1368756
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java PRE-CREATION
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkError.java PRE-CREATION
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java PRE-CREATION
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 1368756
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1368756
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/Repository.java 1368756
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 1368756
  /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 1368756
  /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 1368756
  /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 1368756
  /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 1368756

Diff: https://reviews.apache.org/r/6356/diff/
Testing
-------

Life testing following Sqoop 2 quickstart wiki page: https://cwiki.apache.org/confluence/display/SQOOP/Sqoop2+Quickstart
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6356/#review10000
-----------------------------------------------------------
Thanks for your patch!  Look good to me overall.  One thing though.  Could you please remove TestMPersistableEntity change (which is already in as part of SQOOP-537) so the patch can be applied cleanly?

- Bilung Lee
On Aug. 3, 2012, 10:29 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6356/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 10:29 p.m.)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Description
> -------
>
> I've implemented split of framework and connector specific metadata:
>
> * Framework metadata consists only from set of connection and job forms
> * I've refined Repository and JdbcRepositoryHandler to deal with new framework metadata
> * I've provide implementation for build in Derby metastore
>
>
> This addresses bug SQOOP-535.
>     https://issues.apache.org/jira/browse/SQOOP-535
>
>
> Diffs
> -----
>
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnector.java 1368756
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MFramework.java PRE-CREATION
>   /branches/sqoop2/common/src/test/java/org/apache/sqoop/model/TestMPersistableEntity.java 1368756
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java PRE-CREATION
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkError.java PRE-CREATION
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java PRE-CREATION
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 1368756
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1368756
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/Repository.java 1368756
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 1368756
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 1368756
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 1368756
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 1368756
>   /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 1368756
>
> Diff: https://reviews.apache.org/r/6356/diff/
>
>
> Testing
> -------
>
> Life testing following Sqoop 2 quickstart wiki page: https://cwiki.apache.org/confluence/display/SQOOP/Sqoop2+Quickstart
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6356/
-----------------------------------------------------------

(Updated Aug. 8, 2012, 6:03 a.m.)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Changes
-------

Thanks Bilung for your review, I have updated the patch.
Description
-------

I've implemented split of framework and connector specific metadata:

* Framework metadata consists only from set of connection and job forms
* I've refined Repository and JdbcRepositoryHandler to deal with new framework metadata
* I've provide implementation for build in Derby metastore
This addresses bug SQOOP-535.
    https://issues.apache.org/jira/browse/SQOOP-535
Diffs (updated)
-----

  /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnector.java 1370672
  /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MFramework.java PRE-CREATION
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java PRE-CREATION
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkError.java PRE-CREATION
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java PRE-CREATION
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 1370672
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1370672
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/Repository.java 1370672
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 1370672
  /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 1370672
  /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 1370672
  /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 1370672
  /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 1370672

Diff: https://reviews.apache.org/r/6356/diff/
Testing
-------

Life testing following Sqoop 2 quickstart wiki page: https://cwiki.apache.org/confluence/display/SQOOP/Sqoop2+Quickstart
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6356/#review10024
-----------------------------------------------------------

Ship it!
Ship It!

- Bilung Lee
On Aug. 8, 2012, 6:03 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6356/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 6:03 a.m.)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Description
> -------
>
> I've implemented split of framework and connector specific metadata:
>
> * Framework metadata consists only from set of connection and job forms
> * I've refined Repository and JdbcRepositoryHandler to deal with new framework metadata
> * I've provide implementation for build in Derby metastore
>
>
> This addresses bug SQOOP-535.
>     https://issues.apache.org/jira/browse/SQOOP-535
>
>
> Diffs
> -----
>
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnector.java 1370672
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MFramework.java PRE-CREATION
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java PRE-CREATION
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkError.java PRE-CREATION
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java PRE-CREATION
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 1370672
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1370672
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/Repository.java 1370672
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 1370672
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 1370672
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 1370672
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 1370672
>   /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 1370672
>
> Diff: https://reviews.apache.org/r/6356/diff/
>
>
> Testing
> -------
>
> Life testing following Sqoop 2 quickstart wiki page: https://cwiki.apache.org/confluence/display/SQOOP/Sqoop2+Quickstart
>
>
> Thanks,
>
> Jarek Cecho
>
>