Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-918 Sqoop2: Introduce client API and change Sqoop shell to use it


Copy link to this message
-
Re: Review Request: SQOOP-918 Sqoop2: Introduce client API and change Sqoop shell to use it
Cheolsoo Park 2013-03-11, 02:03

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9717/#review17666
-----------------------------------------------------------

Ship it!
Thank you Jarcec! Looks good to me.

Sorry I don't mean to give you a hard time, but I found a few unnecessary ShellEnvironment.'s as below. Do you mind update the patch? Then, I will commit it.
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
<https://reviews.apache.org/r/9717/#comment37532>

    Can you remove "ShellEnvironment."?

client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java
<https://reviews.apache.org/r/9717/#comment37533>

    Can you remove "ShellEnvironment."?

client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java
<https://reviews.apache.org/r/9717/#comment37534>

    Can you remove "ShellEnvironment."?

client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java
<https://reviews.apache.org/r/9717/#comment37535>

    Can you remove "ShellEnvironment."?

client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java
<https://reviews.apache.org/r/9717/#comment37539>

    Can you remove "ShellEnvironment."?

client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java
<https://reviews.apache.org/r/9717/#comment37540>

    

client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
<https://reviews.apache.org/r/9717/#comment37536>

    Can you remove "ShellEnvironment."?

client/src/main/java/org/apache/sqoop/client/utils/ThrowableDisplayer.java
<https://reviews.apache.org/r/9717/#comment37537>

    Can you remove "ShellEnvironment."?

client/src/main/java/org/apache/sqoop/client/utils/ThrowableDisplayer.java
<https://reviews.apache.org/r/9717/#comment37538>

    Can you remove "ShellEnvironment."?
- Cheolsoo Park
On March 11, 2013, 12:04 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9717/
> -----------------------------------------------------------
>
> (Updated March 11, 2013, 12:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've created first simple SqoopClient API and altered shell to use it. I've noticed that there is a lot of duplicate code in the shell, so I've tried to clean it up. The changes are simple, however are spanning across all shell files, thus making this patch bigger than necessary.
>
> This is first implementation of the SqoopClient API. I'm intending to improve it, for example by caching objects that was already received (especially connector info and resource bundles). As this patch is big enough already, I would prefer to finish this functionality in follow up JIRA.
>
>
> This addresses bug SQOOP-918.
>     https://issues.apache.org/jira/browse/SQOOP-918
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java PRE-CREATION
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java c364aa8856bf02f501b0ca2f3630c8e8c6fd10b1
>   client/src/main/java/org/apache/sqoop/client/core/Environment.java 5d1af26a0e8f96c11c7ef7d8fcfd0013db5ccce6
>   client/src/main/java/org/apache/sqoop/client/core/RequestCache.java 808b9f15d52ba9d3620e094a3640b6a93e2b0848
>   client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java f1e4d685eb0466e916ede21e23f6766f6b263c27
>   client/src/main/java/org/apache/sqoop/client/request/ConnectorRequest.java 9ea9d5db91cb28337ef4b6d997af9d0cd0ef7781
>   client/src/main/java/org/apache/sqoop/client/request/JobRequest.java c2449f5106e2918b5e5068ff41733def68180804
>   client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java PRE-CREATION
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 60dcbb29cb75106c58d4de29a6160c1976bc4d67
>   client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java abec66b4bdcd10bfe6a7b62e421a131083359b5e