-Re: We need patches instead of Pull Requests...
Timothy Chen 2013-02-26, 20:54
I haven't used reviewboard much, from the site it looks it is also looking for diff files to upload though so is similar to attaching patch files in jira. How is reviewboard intergrated with jira?
Sent from my iPhone
On Feb 26, 2013, at 11:46 AM, Henry Saputra <[EMAIL PROTECTED]> wrote:
> Tim, reviewboard should give better integration with JIRA which I believe
> what we actually wanted?
> - Henry
> On Mon, Feb 25, 2013 at 1:39 PM, Timothy Chen <[EMAIL PROTECTED]> wrote:
>> Does reviewboard gives us better integration with Jira or github?
>> On Mon, Feb 25, 2013 at 1:33 PM, Jacques Nadeau <[EMAIL PROTECTED]>
>>> On Mon, Feb 25, 2013 at 12:40 PM, Julian Hyde <[EMAIL PROTECTED]>
>>>> On Feb 25, 2013, at 12:28 PM, Jacques Nadeau <[EMAIL PROTECTED]>
>>>>> Ah, the greatness of the community.
>>> It wasn't sarcastic. I was thinking that committers would have to close
>>> but we can't... I didn't consider making the opener also do the close.
>>>> Here's an idea. If someone opens a pull request, close it immediately
>>>> tell them to log a jira case. The patch URL will still work when a
>>>> committer gets the jira case.
>>> The problem is committers can't close them. If you mean the opener, then
>>> that would work. If we have references in the JIRAs to the direct pull
>>> request pages, then dangling pull requests on the toc page are less of a
>>> problem. Seems okay with me. The only downside is that newcomers may
>>> think that we're behind if they see a long list of incorrectly still open
>>> pull requests.
>>> Other opinions?