Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: Dump RollingFileSink's counter status when agent stops


+
Ted Malaska 2012-09-11, 17:11
+
Brock Noland 2012-09-12, 16:42
+
Hari Shreedharan 2012-09-12, 16:51
Copy link to this message
-
Re: Review Request: Dump RollingFileSink's counter status when agent stops

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7022/
-----------------------------------------------------------

(Updated Sept. 12, 2012, 7:01 p.m.)
Review request for Flume.
Changes
-------

Change from counterGroup to sinkCounter.

Note this is my first time using sinkCounter.  Let me know if I used it right.
Description
-------

Added counting for:
1. events
2. transaction success
3. transaction failure
Also added logging of name and counters at start and stop. Just like NullSink.
This addresses bug FLUME-1537.
    https://issues.apache.org/jira/browse/FLUME-1537
Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java e5e97ff

Diff: https://reviews.apache.org/r/7022/diff/
Testing
-------
Thanks,

Ted Malaska

+
Ted Malaska 2012-09-12, 23:34
+
Hari Shreedharan 2012-09-13, 02:11
+
Ted Malaska 2012-09-13, 13:11