-Re: Please review check-ins
John Vines 2012-08-23, 16:54
If you use eclipse, there is a style provirdes in the contrib directory. If
you use something else, we should see about creating a codestyle for it so
encourage more developers to engage.
Sent from my phone, so pardon the typos and brevity.
On Aug 23, 2012 12:40 PM, "David Medinets" <[EMAIL PROTECTED]> wrote:
> Sorry about the indenting. I need to find a tool to reformat. I
> haven't using FileDataIngest yet. I suppose I should check that some
> automated test exists for it. I'll look.
> On Thu, Aug 23, 2012 at 11:03 AM, Keith Turner <[EMAIL PROTECTED]> wrote:
> > David,
> > The indentation of bcfile.PrintInfo inside the try block is not
> > correct. Please indent. I ran bcfile.PrintInfo and it worked ok.
> > FileDataIngest looks ok. Can you try running to ensure it still works?
> > Keith
> > On Thu, Aug 23, 2012 at 12:01 AM, David Medinets
> > <[EMAIL PROTECTED]> wrote:
> >> Both of the following jira tickets are related to unclosed objects.
> >> The changes were fairly simply and the code compiled after my change.
> >> I did not create any tests or execute the code. If someone can do a
> >> review after a 'svn update', I'd appreciate it.
> >> https://issues.apache.org/jira/browse/ACCUMULO-737
> >> https://issues.apache.org/jira/browse/ACCUMULO-738
> >> Thanks