Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request 13636: SQOOP-1170: Can't import columns with name "public"


+
Erik Selin 2013-08-18, 16:20
+
Jarek Cecho 2013-08-18, 19:00
+
Erik Selin 2013-08-19, 14:51
+
Erik Selin 2013-08-19, 23:00
+
Jarek Cecho 2013-08-19, 14:59
Copy link to this message
-
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 10:59 p.m.)
Review request for Sqoop.
Changes
-------

Add all java reserved keywords as well as tests for each one of them.
Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
Repository: sqoop-trunk
Description
-------

Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
Diffs (updated)
-----

  src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
  src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
  src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc

Diff: https://reviews.apache.org/r/13636/diff/
Testing
-------
Thanks,

Erik Selin

+
Jarek Cecho 2013-08-22, 22:04
+
Erik Selin 2013-08-26, 05:17
+
Jarek Cecho 2013-08-22, 15:47
+
Jarek Cecho 2013-08-22, 21:57
+
Erik Selin 2013-08-22, 15:49